[fix][fn] Reorder Function Worker shutdown to stop scheduler before runtime manager#26136
Merged
Conversation
…untime manager Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24358
Motivation
According to the available logs, it looks like a deadlock occurs when the scheduler thread holds a lock in FunctionRuntimeManager while trying to start a function. This blocks PulsarWorkerService.stop() during its close() call, so it never reaches the logic to stop the scheduler or coordinator. That's why the system keeps hanging during test teardowns.
Modifications
Reordered PulsarWorkerService.stop() to stop scheduling activity before stopping the runtime manager.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes