Skip to content

Fix ConsumerBuilder and PulsarClient document #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sijie merged 2 commits into from
Sep 30, 2018
Merged

Fix ConsumerBuilder and PulsarClient document #2681

sijie merged 2 commits into from
Sep 30, 2018

Conversation

@viirya
Copy link
Member

@viirya viirya commented Sep 30, 2018

Motivation

There are few document error in code. We should fix them.

Modifications

Fixes document in ConsumerBuilder and PulsarClient.

merlimat
merlimat approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie sijie added type/bug The PR fixed a bug or issue reported a bug doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/client labels Sep 30, 2018
@sijie sijie added this to the 2.3.0 milestone Sep 30, 2018
@sijie sijie merged commit 29382dc into apache:master Sep 30, 2018
@viirya
Copy link
Member Author

viirya commented Oct 1, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

Assignees

@viirya viirya

Labels

area/client doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@viirya @merlimat @sijie