Fix invalid range error when getting number of entries #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Oct 3, 2018
Contributor
|
rerun cpp tests |
Contributor
|
rerun integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a topic with metadata similar to #2673, IllegalArgumentException may occur in the following line:
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Line 655 in b2484d9
This is the broker log when the exception has occurred:
invalid_range_error.txt
It is because
readPositionis ahead ofledger.getLastPosition().getNext(), soManagedCursorImpl#getNumberOfEntries()should return 0 as the number of entries to read in that case.I think this issue and #2673 are the result of that
ledger.getLastPosition()is no longer the real last of the managed ledger because of #1550.