Make IdentitySerde handle bytes as well#2848
Merged
srkukarni merged 2 commits intoapache:masterfrom Oct 26, 2018
Merged
Conversation
merlimat
reviewed
Oct 25, 2018
| return str(input).encode('utf-8') | ||
| if type(input) == bytes: | ||
| return input | ||
| raise TypeError |
Contributor
There was a problem hiding this comment.
We should also add context on the type that we got passed here
jerrypeng
approved these changes
Oct 25, 2018
Contributor
Author
|
rerun integration tests |
Contributor
Author
|
rerun java8 tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This will allow bytes to go thru the system unchanged
Modifications
Describe the modifications you've done.
Result
After your change, what will change.