Ignore the current class while going over variables #2970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
rerun integration tests |
merlimat
reviewed
Nov 9, 2018
| localRunArgs.add(new Gson().toJson(sinkConfig)); | ||
| for (Field field : this.getClass().getDeclaredFields()) { | ||
| if (field.getName().startsWith("DEPRECATED")) continue; | ||
| if(field.getName().startsWith("this$0")) continue; |
Contributor
There was a problem hiding this comment.
Since all anonymous classes and lambdas defined within a class will contain $N or $lambdaN, we should ignore everything with a $
merlimat
reviewed
Nov 9, 2018
| for (Field field : this.getClass().getDeclaredFields()) { | ||
| if (field.getName().startsWith("DEPRECATED")) continue; | ||
| if(field.getName().startsWith("this$0")) continue; | ||
| if(field.getName().startsWith("$")) continue; |
Contributor
There was a problem hiding this comment.
I think it should be contains() instead of startsWith(), no? Anything with $ was auto created by compiler anyway.
Contributor
Author
There was a problem hiding this comment.
Good point. I have consolidated the logic
merlimat
approved these changes
Nov 10, 2018
jiazhai
approved these changes
Nov 10, 2018
sijie
approved these changes
Nov 10, 2018
Contributor
Author
|
rerun integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We go over all the declared fields in LocalRunner class to generate the command for localrunner. However one of the items that getDeclartedFields returns is the this$0 which should be ignored.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.