moving pulsar storm tests under tests#3000
Merged
merlimat merged 1 commit intoapache:masterfrom Nov 16, 2018
Merged
Conversation
Contributor
|
If it works and it unblocks the other change I’m ok with this. In general, for integration tests we should start the broker from a container, rather than the embedded broker in same process. |
Contributor
Author
|
@merlimat this really doesn't have to be an integration test. It just needs to be in a separate module |
Contributor
I know, that's why I was saying that if it works and it unblocks the other issue, we can go with this. |
merlimat
approved these changes
Nov 16, 2018
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
Let's make this a "proper" integration test later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Similar issue as:
#2890
but with the tests for pulsar storm. Since pulsar-broker depends on pulsar-client-original and the storm pulsar adaptor depends on the shaded version of it.
After removing the function-metrics module:
#2982
The pulsar storm tests started throwing the following error:
72086 [pulsar-timer-9-1] WARN o.a.p.c.i.ProducerImpl - [persistent://public/crawl/in-partition-1] [crawler-1-1540895529_1] error while closing out batch -- java.lang.NoSuchMethodError: com.scurrilous.circe.checksum.Crc32cIntChecksum.computeChecksum(Lio/netty/buffer/ByteBuf;)I