Skip to content

[Pulsar-Flink] Add Scala Examples#3071

Merged
merlimat merged 4 commits intoapache:masterfrom
erenavsarogullari:PulsarPR_AddFlinkScalaExamples
Nov 28, 2018
Merged

[Pulsar-Flink] Add Scala Examples#3071
merlimat merged 4 commits intoapache:masterfrom
erenavsarogullari:PulsarPR_AddFlinkScalaExamples

Conversation

@erenavsarogullari
Copy link
Copy Markdown
Member

Motivation

This PR aims to help Scala community by adding Scala Examples on Flink Connector.

Modifications

1- FlinkPulsarBatchSinkScalaExample is added for PulsarOutputFormat
2- FlinkPulsarBatchCsvSinkScalaExample is added for PulsarCsvOutputFormat
3- FlinkPulsarBatchJsonSinkScalaExample is added for PulsarJsonOutputFormat
4- Extra comments are added to FlinkPulsarBatchSinkExample

@srkukarni srkukarni requested a review from sijie November 27, 2018 20:56
@srkukarni srkukarni added this to the 2.3.0 milestone Nov 27, 2018
Copy link
Copy Markdown
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erenavsarogullari
Copy link
Copy Markdown
Member Author

rerun java8 tests

@merlimat
Copy link
Copy Markdown
Contributor

@erenavsarogullari It looks like the license headers do not match exactly the pattern and the checker is rejecting them:

2018-11-27\T\23:38:25.874 [INFO] Checking licenses...
2018-11-27\T\23:38:25.899 [WARNING] Missing header in: /home/jenkins/jenkins-slave/workspace/pulsar_precommit_java8/pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/FlinkPulsarBatchJsonSinkScalaExample.scala
2018-11-27\T\23:38:25.899 [WARNING] Missing header in: /home/jenkins/jenkins-slave/workspace/pulsar_precommit_java8/pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/FlinkPulsarBatchCsvSinkScalaExample.scala
2018-11-27\T\23:38:25.899 [WARNING] Missing header in: /home/jenkins/jenkins-slave/workspace/pulsar_precommit_java8/pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/FlinkPulsarBatchSinkScalaExample.scala
2018-11-27\T\23:38:25.903 [INFO] ------------------------------------------------------------------------

It should get fixed with mvn license:format

@erenavsarogullari
Copy link
Copy Markdown
Member Author

@merlimat Thanks. Yes, extra whitespace problem has occurred on license. Patch submitted

@merlimat merlimat merged commit b413c19 into apache:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants