Add log dir creation in ProcessRuntime#3114
Merged
srkukarni merged 1 commit intoapache:masterfrom Dec 4, 2018
Merged
Conversation
jerrypeng
reviewed
Dec 4, 2018
| log.info("Creating function log directory {}", funcLogDir); | ||
| boolean success = createFolder(funcLogDir); | ||
|
|
||
| if (!success) { |
Contributor
There was a problem hiding this comment.
So what if the directory is already there? Shouldn't throw exception because directory is already there
Contributor
There was a problem hiding this comment.
I think this is fine since new File(path).mkdirs() is idempotent
jerrypeng
reviewed
Dec 4, 2018
| } | ||
|
|
||
| private boolean createFolder(final String path) { | ||
| final boolean success = new File(path).mkdirs(); |
Contributor
There was a problem hiding this comment.
We should only attempt to create directories if they are not present
Contributor
There was a problem hiding this comment.
I think this is fine since new File(path).mkdirs() is idempotent
jerrypeng
approved these changes
Dec 4, 2018
srkukarni
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We create the expected log folder in the ProcessRuntime before the function process logger attempts to create it. This is because if multiple instances are launched they can encounter a race condition in creation of the directory.