Skip to content

[Pulsar-Broker-Common] Extend AuthenticationProviderToken UT Coverages#3244

Merged
merlimat merged 2 commits intoapache:masterfrom
erenavsarogullari:PulsarPR_AuthenticationProviderToken_Part_II
Dec 23, 2018
Merged

[Pulsar-Broker-Common] Extend AuthenticationProviderToken UT Coverages#3244
merlimat merged 2 commits intoapache:masterfrom
erenavsarogullari:PulsarPR_AuthenticationProviderToken_Part_II

Conversation

@erenavsarogullari
Copy link
Member

Motivation

This PR aims to extend AuthenticationProviderToken UT Coverages.

Modifications

1- Added new UTs when Secret/Public Key Path is invalid.
2- Removed the unused imports.
3- Post Review comment of #3239 is addressed.

@sijie sijie added area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use labels Dec 22, 2018
@sijie sijie added this to the 2.3.0 milestone Dec 22, 2018
@erenavsarogullari
Copy link
Member Author

rerun java8 tests

@erenavsarogullari
Copy link
Member Author

run java8 tests

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 5dc90b4 into apache:master Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test type/cleanup Code or doc cleanups e.g. remove the outdated documentation or remove the code no longer in use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants