[Issue 3409] Support '--help' option of Pulsar command-line tools#3410
Merged
merlimat merged 9 commits intoapache:masterfrom Feb 22, 2019
Merged
[Issue 3409] Support '--help' option of Pulsar command-line tools#3410merlimat merged 9 commits intoapache:masterfrom
merlimat merged 9 commits intoapache:masterfrom
Conversation
ambition119
reviewed
Jan 24, 2019
| Environment variables: | ||
| PULSAR_LOG_CONF Log4j configuration file (default $DEFAULT_LOG_CONF) | ||
| PULSAR_CLIENT_CONF Configuration file for client (default: $DEFAULT_CLIENT_CONF) | ||
| PULSAR_CLIENT_CONF Configuration file for client (default: $DEFAULT_CLIENT_CONF) |
Contributor
There was a problem hiding this comment.
The indentation here is also fix by the way.
help
Contributor
There was a problem hiding this comment.
Changed, thanks!
well done.
Contributor
|
👍 |
ambition119
approved these changes
Jan 24, 2019
Member
|
retest this please |
sijie
approved these changes
Jan 25, 2019
Member
|
retest this please |
Member
|
run cpp tests |
4 similar comments
Contributor
Author
|
run cpp tests |
Contributor
|
run cpp tests |
Member
|
run cpp tests |
Contributor
|
run cpp tests |
Member
|
run cpp tests |
Member
|
run cpp tests |
Member
|
run cpp tests |
1 similar comment
Contributor
|
run cpp tests |
Contributor
Author
Contributor
Author
|
run java8 tests |
aahmed-se
approved these changes
Feb 15, 2019
Member
|
run java8 tests |
Contributor
|
Merged in 2.3.1 at 043f32f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3409
Modifications
Support '--help' option of Pulsar command-line tools and modify usage of 'pulsar-perf'.