Skip to content

[distribution] remove pulsar-io-debezium nar package#3656

Merged
merlimat merged 1 commit intoapache:masterfrom
sijie:fix_debezium
Feb 22, 2019
Merged

[distribution] remove pulsar-io-debezium nar package#3656
merlimat merged 1 commit intoapache:masterfrom
sijie:fix_debezium

Conversation

@sijie
Copy link
Member

@sijie sijie commented Feb 22, 2019

Fixes #3651

Motivation

pulsar-io-debezium is a normal module but not a connector package.
it was added as a connector package by mistake at #3601. This would
cause failing to load connectors during broker starts up.

Modifications

  • remove nar plugin from pulsar-io-debezium
  • remove pulsar-io-debezium from distribution
  • add pulsar-io-kafka-connect-adaptor in the website

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

*Motivation*

Fixes apache#3651

`pulsar-io-debezium` is a normal module but not a connector package.
it was added as a connector package by mistake at apache#3601. This would
cause failing to load connectors during broker starts up.

*Changes*

- remove nar plugin from `pulsar-io-debezium`
- remove `pulsar-io-debezium` from distribution
- add `pulsar-io-kafka-connect-adaptor` in the website
@sijie sijie added type/bug The PR fixed a bug or issue reported a bug doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/build area/connector labels Feb 22, 2019
@sijie sijie self-assigned this Feb 22, 2019
@sijie sijie requested review from jiazhai and merlimat February 22, 2019 03:12
@sijie
Copy link
Member Author

sijie commented Feb 22, 2019

run cpp tests

@merlimat merlimat merged commit bd62dab into apache:master Feb 22, 2019
@merlimat merlimat added this to the 2.3.1 milestone Feb 22, 2019
merlimat pushed a commit that referenced this pull request Mar 29, 2019
*Motivation*

Fixes #3651

`pulsar-io-debezium` is a normal module but not a connector package.
it was added as a connector package by mistake at #3601. This would
cause failing to load connectors during broker starts up.

*Changes*

- remove nar plugin from `pulsar-io-debezium`
- remove `pulsar-io-debezium` from distribution
- add `pulsar-io-kafka-connect-adaptor` in the website
@merlimat
Copy link
Contributor

merlimat commented Apr 1, 2019

Merged in 2.3.1 at
d270056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build area/connector doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments