report sys errors when failed to produce successfully#3668
Merged
jerrypeng merged 13 commits intoapache:masterfrom Feb 24, 2019
Merged
report sys errors when failed to produce successfully#3668jerrypeng merged 13 commits intoapache:masterfrom
jerrypeng merged 13 commits intoapache:masterfrom
Conversation
merlimat
approved these changes
Feb 22, 2019
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
Should we also have a counter of successfull/failed publishes?
Contributor
|
run java8 tests |
1 similar comment
Contributor
Author
|
run java8 tests |
merlimat
reviewed
Feb 22, 2019
Contributor
There was a problem hiding this comment.
CompletableFuture<MessageId> future = msg.sendAsync();
future.thenAccept(messageId -> record.ack())
.exceptionally(getPublishErrorHandler(record))
future.join();
merlimat
approved these changes
Feb 22, 2019
Contributor
Author
|
rerun java8 tests |
Contributor
|
run java8 tests |
merlimat
pushed a commit
that referenced
this pull request
Mar 29, 2019
* report sys errors when failed to produce sucessfully * enhancing error message * adding metrics to context publish * enhancing error logging and adding java error handling * fixing tests * cleaning up * addressing comments and fix bug * cleaning up * fix bug * fix test * check is none * fix unit test * cleaning up
Contributor
|
Merged in 2.3.1 at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For python functions, when there are failures producing messages, the errors are not reported or log which makes it hard to determine if there is a problem