Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip#3743
Closed
jiazhai wants to merge 2 commits intoapache:masterfrom
Closed
Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip#3743jiazhai wants to merge 2 commits intoapache:masterfrom
jiazhai wants to merge 2 commits intoapache:masterfrom
Conversation
…tion (apache#3312)" This reverts commit 231db03.
Member
Author
Member
Member
Author
Contributor
1 task
Contributor
Member
Author
Member
Author
|
rerun java8 tests |
lovelle
added a commit
to lovelle/pulsar
that referenced
this pull request
Mar 6, 2019
Fixes apache#3743 issue. Return previous instance of a consumer in the subscription processed should only be considered with the scope of the same topic. Modifications: - Remove optimization of duplicated consumers for multi topics subscribe and pattern topics subscribe, this should be handled with a different approach. - Filter consumers for the same topic name. - Filter consumers which are connected to broker, this is not necessary to fix this issue but is a good thing to do. - Add test that verifies that same subscription will allow different consumers instance for different topics.
Member
Author
|
close this issue for more discussion please reference pr #3746 |
merlimat
pushed a commit
that referenced
this pull request
Mar 7, 2019
…3746) Fixes #3743 issue. Return previous instance of a consumer in the subscription processed should only be considered with the scope of the same topic. Modifications: - Remove optimization of duplicated consumers for multi topics subscribe and pattern topics subscribe, this should be handled with a different approach. - Filter consumers for the same topic name. - Filter consumers which are connected to broker, this is not necessary to fix this issue but is a good thing to do. - Add test that verifies that same subscription will allow different consumers instance for different topics.
merlimat
pushed a commit
that referenced
this pull request
Mar 29, 2019
…3746) Fixes #3743 issue. Return previous instance of a consumer in the subscription processed should only be considered with the scope of the same topic. Modifications: - Remove optimization of duplicated consumers for multi topics subscribe and pattern topics subscribe, this should be handled with a different approach. - Filter consumers for the same topic name. - Filter consumers which are connected to broker, this is not necessary to fix this issue but is a good thing to do. - Add test that verifies that same subscription will allow different consumers instance for different topics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 231db03.
which is commit in #3312