[pulsar-webscoket] avoid creating temp list of metrics on every-metrics generator #3792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jai1
approved these changes
Mar 9, 2019
Contributor
jai1
left a comment
jai1
left a comment
There was a problem hiding this comment.
All methods are synchronized - not sure if we still need the tempMetricsCollection, I mean why can't we just clear and repopulate metricsCollection
Contributor
Author
That's true. We can now remove synchronization on getMetrics method. let me fix it. |
jai1
approved these changes
Mar 9, 2019
Contributor
jai1
left a comment
jai1
left a comment
There was a problem hiding this comment.
Don't we need metricsCollection to be volatile in order to remove synchronized.
sijie
approved these changes
Mar 9, 2019
merlimat
pushed a commit
that referenced
this pull request
Mar 29, 2019
…cs generator (#3792) * [pulsar-webscoket] avoid creating temp list of metrics on every-metrics generator * fix non-sync getMetrics
Contributor
|
Merged in 2.3.1 at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid creating new list every time when websocket generate metrics.