[pulsar-broker] add valid-readPosition check before setting readPosition at cursor#3881
Merged
rdhabalia merged 2 commits intoapache:masterfrom May 18, 2019
Merged
[pulsar-broker] add valid-readPosition check before setting readPosition at cursor#3881rdhabalia merged 2 commits intoapache:masterfrom
rdhabalia merged 2 commits intoapache:masterfrom
Conversation
merlimat
approved these changes
Mar 22, 2019
Contributor
Author
|
rerun java8 tests |
sijie
approved these changes
Apr 9, 2019
Contributor
Author
|
rerun integration tests |
Contributor
Author
|
rerun integration tests |
1 similar comment
Contributor
Author
|
rerun integration tests |
Contributor
Author
|
rerun java8 tests |
Contributor
Author
|
rerun java8 tests |
4 similar comments
Contributor
Author
|
rerun java8 tests |
Contributor
Author
|
rerun java8 tests |
Contributor
Author
|
rerun java8 tests |
Contributor
Author
|
rerun java8 tests |
Contributor
|
run java8 tests |
Contributor
Author
|
rerun java8 tests |
1 similar comment
Contributor
Author
|
rerun java8 tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Recently we saw instance where cursor's readPosition was behind markDeletePosition. So, adding check for valid-readPosition while setting up readPosition.