Skip to content

[ERROR] Throw error explicitly on param value not in range#3950

Merged
merlimat merged 1 commit intoapache:masterfrom
shiv4289:patch-2
Apr 1, 2019
Merged

[ERROR] Throw error explicitly on param value not in range#3950
merlimat merged 1 commit intoapache:masterfrom
shiv4289:patch-2

Conversation

@shiv4289
Copy link
Contributor

Motivation

The code checks if value is in valid range. If yes, sets it else ignores param and returns silently doing nothing.

Modifications

Explicitly throw IllegalArgumentException if param value not in valid range.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API: (no)
  • The schema: ( no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • If yes, how is the feature documented? (not applicable )

@sijie sijie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages component/flink labels Mar 29, 2019
@sijie sijie added this to the 2.4.0 milestone Mar 29, 2019
@shiv4289
Copy link
Contributor Author

run java8 tests

2 similar comments
@sijie
Copy link
Member

sijie commented Mar 30, 2019

run java8 tests

@shiv4289
Copy link
Contributor Author

run java8 tests

@merlimat merlimat merged commit daa0a18 into apache:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants