[Issue 3966] [pulsar-io] Specify the RedisSink type as Bytes by default#3972
Merged
merlimat merged 2 commits intoapache:masterfrom Apr 4, 2019
Merged
[Issue 3966] [pulsar-io] Specify the RedisSink type as Bytes by default#3972merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
merlimat
reviewed
Apr 3, 2019
| ) | ||
| @Slf4j | ||
| public class RedisSink<T> implements Sink<T> { | ||
| public class RedisSink<T> implements Sink<byte[]> { |
Contributor
There was a problem hiding this comment.
Should it then be RedisSink instead of RedisSink<T> ?
sijie
reviewed
Apr 3, 2019
| for (Record<byte[]> record: recordsToFlush) { | ||
| try { | ||
| // records with null keys or values will be ignored | ||
| byte[] key = toBytes("key", record.getKey().orElse(null)); |
Member
There was a problem hiding this comment.
I think we can get rid of toBytes here, no?
Contributor
Author
There was a problem hiding this comment.
yeah, it's redundant in this case. Changed.
sijie
approved these changes
Apr 4, 2019
merlimat
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3966
Modifications
Modify RedisSink to use Bytes instead of no specific type.