Fixed issue in backoff builder configuration#3984
Merged
sijie merged 1 commit intoapache:masterfrom Apr 9, 2019
Merged
Conversation
srkukarni
approved these changes
Apr 5, 2019
jerrypeng
approved these changes
Apr 5, 2019
Contributor
Author
|
run java8 tests |
sijie
approved these changes
Apr 8, 2019
Contributor
|
rerun java8 tests |
merlimat
force-pushed
the
master
branch
2 times, most recently
from
a0c7708 to
6b32ae2
Compare
Contributor
Author
|
run integration tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #3848 there was a mismatch of the values when converting from constructor to builder. The values for
setMandatoryStop()andsetMax()were inverted.That makes a client to keep reconnecting every 100 millis, instead of doing the expected backoff.