[python][schemaregistry] Handle subrecords in complex types#4050
Merged
Conversation
merlimat
reviewed
Apr 15, 2019
Contributor
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
Change LGTM. Can you also add unit tests for this in pulsar-client-cpp/python/schema_test.py ?
merlimat
added
the
type/enhancement
Contributor
Author
|
OK will do. |
sijie
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When declaring a schema in the python client, the provided complex types such as
Record,ArrayorMapdoes not compose well because the records schema must be included in the parent schema instead of the type.Modifications
This PR adds a rule for each complex type to use the schema instead of the type in the parent schema build.