Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects#4059
Merged
merlimat merged 2 commits intoapache:masterfrom Apr 22, 2019
Merged
Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects#4059merlimat merged 2 commits intoapache:masterfrom
merlimat merged 2 commits intoapache:masterfrom
Conversation
merlimat
requested review from
asfsecurity,
jerrypeng,
nkurihar and
sijie
and removed request for
asfsecurity
jerrypeng
approved these changes
Apr 16, 2019
lovelle
reviewed
Apr 16, 2019
.../java/org/apache/pulsar/tests/integration/auth/token/PulsarTokenAuthenticationBaseSuite.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run java8 tests |
sijie
approved these changes
Apr 18, 2019
Contributor
|
rerun java8 tests |
Contributor
Author
|
run java8 tests |
2 similar comments
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to what done in #3869 for PulsarAdmin, this is fixing HTTP redirects when are internally followed by the Pulsar proxy. The
Authorizationheader with the token info needs to be carried over after the redirect.