Skip to content

[Issue#4159][pulsar-testclient] Added ['-p','--max-outstanding-across-partitions'] parameter to the producer performance benchmark#4160

Merged
sijie merged 6 commits into
apache:masterfrom
kuangye098:master
Apr 29, 2019
Merged

[Issue#4159][pulsar-testclient] Added ['-p','--max-outstanding-across-partitions'] parameter to the producer performance benchmark#4160
sijie merged 6 commits into
apache:masterfrom
kuangye098:master

Conversation

@kuangye098
Copy link
Copy Markdown
Contributor

@kuangye098 kuangye098 commented Apr 28, 2019 •
edited
Loading

Fixes: #4159
Master Issue: #4159

Modifications

  • Added ['-p','--max-multiPartition-outstanding'] parameter to the producer performance benchmark

@kuangye098 kuangye098 changed the title [Issue#4159][pulsar-testclient]Added ['-p','--max-multiPartition-outstanding'] parameter to the producer performance benchmark [Issue#4159][pulsar-testclient] Added ['-p','--max-multiPartition-outstanding'] parameter to the producer performance benchmark Apr 28, 2019
sijie
sijie reviewed Apr 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuangye098 left a few suggestions.

Comment thread pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java Outdated
Comment thread pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java Outdated
sijie and others added 4 commits April 29, 2019 09:16
@sijie @kuangye098
Update pulsar-testclient/src/main/java/org/apache/pulsar/testclient/P…
11fb2c8 
…erformanceProducer.java

Co-Authored-By: kuangye098 <732184166@qq.com>
@sijie @kuangye098
Update pulsar-testclient/src/main/java/org/apache/pulsar/testclient/P…
a494858 
…erformanceProducer.java

Co-Authored-By: kuangye098 <732184166@qq.com>
@kuangye098
In the producer performance benchmark test, change the [max-multiPart…
0ab571e 
…ition-outstanding] parameter to [max-outstanding-across-partitions] and modify its description.
@kuangye098
Merge remote-tracking branch 'origin/master'
2c8767e
@kuangye098 kuangye098 changed the title [Issue#4159][pulsar-testclient] Added ['-p','--max-multiPartition-outstanding'] parameter to the producer performance benchmark [Issue#4159][pulsar-testclient] Added ['-p','--max-outstanding-across-partitions'] parameter to the producer performance benchmark Apr 29, 2019
jiazhai
jiazhai approved these changes Apr 29, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for found and fix the issue

@sijie sijie added area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Apr 29, 2019
@sijie sijie added this to the 2.4.0 milestone Apr 29, 2019
@sijie sijie merged commit d85b0c9 into apache:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

Assignees

@kuangye098 kuangye098

Labels

area/client type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

The maximum number of outstanding messages (--max-outstanding) configuration may be inaccurate when the topic is multi-partitioned

3 participants

@kuangye098 @sijie @jiazhai