Use multi-stage build for Docker images#4184
Merged
merlimat merged 6 commits intoapache:masterfrom May 18, 2019
Merged
Conversation
merlimat
added
the
type/enhancement
merlimat
requested review from
asfsecurity,
ivankelly,
jerrypeng,
nkurihar,
sijie and
srkukarni
aahmed-se
approved these changes
Apr 30, 2019
Contributor
|
run java8 tests |
Contributor
|
run integration tests |
Contributor
|
something is missing |
Contributor
|
ivankelly
approved these changes
May 6, 2019
aahmed-se
reviewed
May 17, 2019
|
|
||
| RUN easy_install pip | ||
| RUN pip install kazoo pyyaml | ||
| RUN easy_install3 pip |
Contributor
There was a problem hiding this comment.
need pip3 install kazoo pyyaml
Contributor
Author
There was a problem hiding this comment.
Do we need both for py2 and py3?
Contributor
There was a problem hiding this comment.
I am in favor of dropping python2. I think everything works with py3 except the dashboard.
aahmed-se
approved these changes
May 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following from the discussion on #3602, changing the DockerFile to use multi-stage build.
This avoids having the Pulsar tgz to be included twice in the image (because of the
mv /apache-pulsar-2.x.y /pulsar).The image size goes from 1G to < 400MB.