Skip to content

Check for existance of schemaInfo before accessing it#4203

Merged
srkukarni merged 1 commit into
apache:masterfrom
srkukarni:fix_kvschema_bugs
May 4, 2019
Merged

Check for existance of schemaInfo before accessing it#4203
srkukarni merged 1 commit into
apache:masterfrom
srkukarni:fix_kvschema_bugs

Conversation

@srkukarni
Copy link
Copy Markdown
Contributor

Motivation

Sometimes SchemaInfo can be null. Check for those conditions.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@srkukarni srkukarni added this to the 2.4.0 milestone May 4, 2019
@srkukarni srkukarni requested review from jerrypeng and sijie May 4, 2019 16:40
@srkukarni srkukarni self-assigned this May 4, 2019
@srkukarni
Copy link
Copy Markdown
Contributor Author

run cpp tests

@srkukarni srkukarni merged commit 96bf9f6 into apache:master May 4, 2019
@srkukarni srkukarni deleted the fix_kvschema_bugs branch May 4, 2019 23:56
Copy link
Copy Markdown
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, when will the schema info be null? I thought we have schema info even for bytes schema, no?

@srkukarni
Copy link
Copy Markdown
Contributor Author

SerdeSchema :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants