Skip to content

Update ingress port from server to 80#4204

Merged
merlimat merged 1 commit into
apache:masterfrom
waterscar:patch-1
May 7, 2019
Merged

Update ingress port from server to 80#4204
merlimat merged 1 commit into
apache:masterfrom
waterscar:patch-1

Conversation

@waterscar
Copy link
Copy Markdown
Contributor

<--

Contribution Checklist

  • Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where XYZ should be replaced by the actual issue number.
    Skip Issue XYZ if there is no associated github issue for this pull request.
    Skip component if you are unsure about which is the best component. E.g. [docs] Fix typo in produce method.

  • Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

  • Each pull request should address only one issue, not mix up code from multiple issues.

  • Each commit in the pull request has a meaningful commit message

  • Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
-->

Simply fix the typo(?) issue in the ingress port default value.

@sijie
Copy link
Copy Markdown
Member

sijie commented May 6, 2019

@waterscar nice catch!

@sijie sijie added this to the 2.4.0 milestone May 6, 2019
@sijie
Copy link
Copy Markdown
Member

sijie commented May 6, 2019

run java8 tests

@merlimat merlimat merged commit 0ae032d into apache:master May 7, 2019
@waterscar
Copy link
Copy Markdown
Contributor Author

Some comments after:
Even though I couldn't find any official document from kubernetes describing this, but it does support using the port name of the service in the servicePort field of ingress. And it is actually quite commonly used in helm charts.
So it was not a typo issue and original configuration does work :)

@waterscar waterscar deleted the patch-1 branch June 19, 2019 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants