Skip to content

[docs] Documentation on configuring functions runtime#4263

Merged
jiazhai merged 5 commits intoapache:masterfrom
sijie:functions_deploy_mode
May 22, 2019
Merged

[docs] Documentation on configuring functions runtime#4263
jiazhai merged 5 commits intoapache:masterfrom
sijie:functions_deploy_mode

Conversation

@sijie
Copy link
Member

@sijie sijie commented May 11, 2019

Fixes #4171
Fixes #3073

@sijie sijie added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/function labels May 11, 2019
@sijie sijie added this to the 2.4.0 milestone May 11, 2019
@sijie sijie requested review from jerrypeng, jiazhai and srkukarni May 11, 2019 11:16
@sijie sijie self-assigned this May 11, 2019
@sijie
Copy link
Member Author

sijie commented May 11, 2019

@jennifer88huang ^


## Configure Kubernetes runtime

Configuring Kubernetes runtime is as simple as configuring the other two runtimes. You can just uncomment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the meaning of "uncomment"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) try google it. @jennifer88huang

https://www.google.com.hk/search?newwindow=1&safe=strict&ei=-9PYXJWHEPKwmAWSqZdQ&q=uncomment&oq=uncomment&gs_l=psy-ab.3..0i10i70i255j0i10l3j0i67j0l5.1725.1725..2054...0.0..0.104.104.0j1......0....1..gws-wiz.t1uIqcWY1uA

Copy link
Contributor

@Jennifer88huang-zz Jennifer88huang-zz May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiazhai Thank you very much for your information. I'll pay attention to my word usage next time.
When you ''uncomment" sth in code, you actually want to enable some configuration options; in some cases, you just disable it with "comment", that's why we use comment lines in code. Here I want to tell @sijie, he could use "enable" / "disable" or other similar words to replace "uncomment"/"comment" in technical writing. When he explains the meaning, he will realize it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer88huang I think from technical writing perspective, "enabling" and "disabling" are probably better. However sometimes "enabling" and "disabling" are too general that users have no idea to enable or disable. Can we use a phrase like "enabling sth by uncommenting ..."?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it's much better.

@merlimat
Copy link
Contributor

run integration tests
run java8 tests

@merlimat
Copy link
Contributor

run java8 tests

@sijie
Copy link
Member Author

sijie commented May 18, 2019

run java8 tests

@sijie
Copy link
Member Author

sijie commented May 19, 2019

run java8 tests

1 similar comment
@sijie
Copy link
Member Author

sijie commented May 20, 2019

run java8 tests

@sijie
Copy link
Member Author

sijie commented May 22, 2019

run integration tests

@jiazhai jiazhai merged commit dea890a into apache:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/function doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulsar Functions documentation does not mention deploying Functions workers in containers [Question] cluster mode fuctions in Kubernetes cluster

4 participants