Skip to content

Add missed serialization schema argument for PulsarOutputFormat #4373

Merged
sijie merged 1 commit intoapache:masterfrom
liketic:bugfix-1
May 29, 2019
Merged

Add missed serialization schema argument for PulsarOutputFormat #4373
sijie merged 1 commit intoapache:masterfrom
liketic:bugfix-1

Conversation

@liketic
Copy link
Contributor

@liketic liketic commented May 26, 2019

The constructor of PulsarOutputFormat expects a serializationSchema passed in otherwise it's member serializationSchema will be assigned by itself.

Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice catch!

@sijie sijie added this to the 2.4.0 milestone May 26, 2019
@sijie
Copy link
Member

sijie commented May 26, 2019

run integration tests

2 similar comments
@sijie
Copy link
Member

sijie commented May 26, 2019

run integration tests

@liketic
Copy link
Contributor Author

liketic commented May 29, 2019

run integration tests

@sijie sijie merged commit 4d1b2ff into apache:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments