[Issue 4347] ClientAPI ReaderBuilder.loadConf() not working#4382
Merged
codelipenghui merged 1 commit intoapache:masterfrom Jun 13, 2019
Merged
[Issue 4347] ClientAPI ReaderBuilder.loadConf() not working#4382codelipenghui merged 1 commit intoapache:masterfrom
codelipenghui merged 1 commit intoapache:masterfrom
Conversation
sijie
reviewed
May 27, 2019
Member
sijie
left a comment
There was a problem hiding this comment.
@ambition119 can you write a unit test to reproduce this issue? so that we can confirm that your pull request fixes it.
Contributor
Author
done, this solve like https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java#L62 |
Member
|
@ambition119 can you rebase your pull request to latest master to fix the integration tests error? |
sijie
requested changes
Jun 1, 2019
pulsar-client/src/test/java/org/apache/pulsar/client/impl/BuildersTest.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/test/java/org/apache/pulsar/client/impl/BuildersTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run java8 tests org.apache.pulsar.functions.worker.PulsarFunctionE2ESecurityTest.testAuthorizationWithAnonymousUser |
Member
|
run java8 tests |
sijie
approved these changes
Jun 12, 2019
codelipenghui
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #4347
Motivation
MessageIdis a interface, not supportmapper.readValue()fromconf.set("startMessageId", new MessageIdImpl()).If support, modify code to
mapper.forType(MessageIdImpl.class)or use jackson annotationso I thank use
@JsonIgnorethenbuilder.startMessageId()is the easiest solution.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation