Remove pulsar-client-api from shaded jar #4491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@merlimat I think this is a no-brainer now that you have merged a proper fix to the jpms split-package issue. |
Contributor
Author
|
run cpp tests |
merlimat
added
the
type/enhancement
Contributor
|
run java8 tests |
1 similar comment
Contributor
|
run java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The split package issue has been properly fixed with #4445 so there is no need for workarounds anymore. This PR removes the previously added workaround as merged by #4257 which was to include the pulsar-client-api jar in the pulsar-client-all shaded artifact.