Add subscription modes for java client doc.#4533
Merged
sijie merged 4 commits intoapache:masterfrom Jun 20, 2019
Merged
Conversation
Contributor
Author
|
@jennifer88huang @Anonymitaet Please help review this PR, i copied the document to google doc: https://docs.google.com/document/d/1a0OD7azjAZpCmiYw9fV8kagtXSwTkD004oC3Mz636eU/edit?usp=sharing |
Contributor
|
Good idea, I'll give comments in the google doc. |
Contributor
|
@codelipenghui I've finished reviewing the file in Google doc, you can check my comments there. If there is any issue, feel free to contact me. |
Contributor
Author
|
@jennifer88huang Thanks for the review, i have synced updates to this PR. |
Contributor
Author
Contributor
Author
|
run java8 tests |
sijie
requested changes
Jun 18, 2019
site2/docs/client-libraries-java.md
Outdated
|
|
||
| > Note: | ||
| > | ||
| > If a topic is a partitioned topic, the partitioned topic only has one active consumer, and messages of the partition are distributed to multiple consumers. |
Member
There was a problem hiding this comment.
hmm I think the description here is misleading.
I think it should contain two points:
- each partition only has one active consumer
- messages of one partition only distributed to one consumer
- multiple partitions are distributed to multiple consumers
@codelipenghui right?
Contributor
Author
There was a problem hiding this comment.
yes, updated
sijie
approved these changes
Jun 18, 2019
jiazhai
approved these changes
Jun 19, 2019
wolfstudy
reviewed
Jun 19, 2019
wolfstudy
approved these changes
Jun 19, 2019
Co-Authored-By: 冉小龙 <rxl5555555@qq.com>
Contributor
Author
|
run java8 tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add document for java client to describe how to use each subscription modes and the difference between each subscription modes.
Modifications
Add subscription modes section for java client doc.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation