Skip to content

Comments

Add subscription modes for java client doc.#4533

Merged
sijie merged 4 commits intoapache:masterfrom
codelipenghui:subscriptions_mode_java_client_doc
Jun 20, 2019
Merged

Add subscription modes for java client doc.#4533
sijie merged 4 commits intoapache:masterfrom
codelipenghui:subscriptions_mode_java_client_doc

Conversation

@codelipenghui
Copy link
Contributor

Motivation

Add document for java client to describe how to use each subscription modes and the difference between each subscription modes.

Modifications

Add subscription modes section for java client doc.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui
Copy link
Contributor Author

@jennifer88huang @Anonymitaet Please help review this PR, i copied the document to google doc: https://docs.google.com/document/d/1a0OD7azjAZpCmiYw9fV8kagtXSwTkD004oC3Mz636eU/edit?usp=sharing

@Jennifer88huang-zz
Copy link
Contributor

Good idea, I'll give comments in the google doc.

@Jennifer88huang-zz
Copy link
Contributor

@codelipenghui I've finished reviewing the file in Google doc, you can check my comments there. If there is any issue, feel free to contact me.

@codelipenghui
Copy link
Contributor Author

@jennifer88huang Thanks for the review, i have synced updates to this PR.

@codelipenghui
Copy link
Contributor Author

@merlimat @sijie @jiazhai Please help review the document if you have time.

@codelipenghui
Copy link
Contributor Author

run java8 tests

@sijie sijie added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/task labels Jun 18, 2019

> Note:
>
> If a topic is a partitioned topic, the partitioned topic only has one active consumer, and messages of the partition are distributed to multiple consumers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I think the description here is misleading.

I think it should contain two points:

  • each partition only has one active consumer
  • messages of one partition only distributed to one consumer
  • multiple partitions are distributed to multiple consumers

@codelipenghui right?

Copy link
Contributor Author

@codelipenghui codelipenghui Jun 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, updated

@codelipenghui codelipenghui requested a review from sijie June 18, 2019 11:08
Co-Authored-By: 冉小龙 <rxl5555555@qq.com>
@codelipenghui
Copy link
Contributor Author

run java8 tests

@sijie sijie added this to the 2.4.0 milestone Jun 20, 2019
@sijie sijie merged commit aec968a into apache:master Jun 20, 2019
@codelipenghui codelipenghui deleted the subscriptions_mode_java_client_doc branch May 19, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants