[doc] Add code samples for Protobuf and Avro schemas in java documentation #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Jul 3, 2019
site2/docs/client-libraries-java.md
Outdated
|
|
||
| ```java | ||
| Schema<MyProtobuf> protobufSchema = ProtobufSchema.of(MyProtobuf.class); | ||
| Producer<MyProtobuf> protobufProducer = client.newProducer(protobufSchema) |
Contributor
There was a problem hiding this comment.
The preferred form should be:
client.newProducer(Schema.PROTOBUF(MyProtobuf.class))
Contributor
Author
There was a problem hiding this comment.
yes, I will change it. In my project the Schema.PROTOBUF form is used, but I wanted to keep it consistent with the sample for the JSON schema.
Contributor
There was a problem hiding this comment.
Oh, I see. Do you mind also changing the example for JSON?
Contributor
Author
There was a problem hiding this comment.
sure, I will update it
site2/docs/client-libraries-java.md
Outdated
|
|
||
| ```java | ||
| Schema<MyAvro> avroSchema = AvroSchema.of(MyAvro.class); | ||
| Producer<MyAvro> avroProducer = client.newProducer(avroSchema) |
Contributor
There was a problem hiding this comment.
Same here:
client.newProducer(Schema.AVRO(MyProtobuf.class))
merlimat
added
the
doc
…e preferred form.
easyfan
pushed a commit
to easyfan/pulsar
that referenced
this pull request
Jul 26, 2019
…ation (apache#4670) * Add code samples for Protobuf and Avro schemas in java * Update the code snippets for JSON, Protobuf, and Avro schemas with the preferred form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We could not find Java examples which would include Avro and Protobuf schemas, but from the other documentation page it was clear that Pulsar supports them.
Modification
Two code snippets (one for Protobuf and the other one for Avro) were added to the Schema example chapter.