Skip to content

[Doc] Add Notes for *Create Topic*#4938

Merged
sijie merged 1 commit intoapache:masterfrom
Anonymitaet:create_topic
Aug 15, 2019
Merged

[Doc] Add Notes for *Create Topic*#4938
sijie merged 1 commit intoapache:masterfrom
Anonymitaet:create_topic

Conversation

@Anonymitaet
Copy link
Copy Markdown
Member

@Anonymitaet Anonymitaet commented Aug 12, 2019

Fix #4897

@cumtwwei @sijie could you please help review? Thank you

@wolfstudy wolfstudy added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 12, 2019
Copy link
Copy Markdown
Contributor

@Jennifer88huang-zz Jennifer88huang-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no language issue in the note.
A tiny suggestion: if you add the same note several times in a doc, it indicates the note is very important, it's better to add it in a general and obvious place once for all. It's easy to find and maintain.

@Anonymitaet
Copy link
Copy Markdown
Member Author

Anonymitaet commented Aug 12, 2019

@jennifer88huang thanks for your suggestion, while this note has been added for 3 documents and 5 places.
Since the note is pretty important and easily ignored when users creating topics, we'd better emphasis it and remind users in every "create topic" related section.

@sijie sijie added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Aug 14, 2019
@sijie sijie added this to the 2.5.0 milestone Aug 14, 2019
@sijie
Copy link
Copy Markdown
Member

sijie commented Aug 14, 2019

run cpp tests
run java8 tests

@sijie
Copy link
Copy Markdown
Member

sijie commented Aug 15, 2019

run cpp tests

@Anonymitaet
Copy link
Copy Markdown
Member Author

@sijie could you please help merge this PR? Thank you

@sijie sijie merged commit 900d81a into apache:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Add notes for creating topic

4 participants