[Doc] Add Notes for *Create Topic*#4938
Merged
sijie merged 1 commit intoapache:masterfrom Aug 15, 2019
Anonymitaet:create_topic
Merged
[Doc] Add Notes for *Create Topic*#4938sijie merged 1 commit intoapache:masterfrom Anonymitaet:create_topic
sijie merged 1 commit intoapache:masterfrom
Anonymitaet:create_topic
Conversation
Contributor
Jennifer88huang-zz
left a comment
There was a problem hiding this comment.
There is no language issue in the note.
A tiny suggestion: if you add the same note several times in a doc, it indicates the note is very important, it's better to add it in a general and obvious place once for all. It's easy to find and maintain.
Member
Author
|
@jennifer88huang thanks for your suggestion, while this note has been added for 3 documents and 5 places. |
sijie
approved these changes
Aug 14, 2019
Member
|
run cpp tests |
Member
|
run cpp tests |
Member
Author
|
@sijie could you please help merge this PR? Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4897
@cumtwwei @sijie could you please help review? Thank you