Skip to content

Add Github workflow for gated checkin#5064

Closed
aahmed-se wants to merge 9 commits intomasterfrom
ci_1
Closed

Add Github workflow for gated checkin#5064
aahmed-se wants to merge 9 commits intomasterfrom
ci_1

Conversation

@aahmed-se
Copy link
Contributor

@aahmed-se aahmed-se commented Aug 28, 2019

We are adding support for complementary ci cd jobs based on Github actions. these jobs will run in parallel and thereafter we can deprecate the jenkins check in jobs.

@aahmed-se aahmed-se self-assigned this Aug 28, 2019
Enchance Retry anaylzer
Fix test thread count
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general question, how do we get the surefire-reports for each job? In other words, how do I know which tests are failing and where can I find the error log?


- name: run unit tests
run: |
java -version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we specify the java and javac version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added action to choose jdk

javac -version
export TEST_TIMEOUT_ENV_MILLIS=30000
export TEST_RETRY_COUNT=3
mvn install No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mvn install
mvn -B clean license:check install
src/check-binary-license ./distribution/server/target/apache-pulsar-*-bin.tar.gz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

run: |
java -version
javac -version
mvn install -Pdocker -DskipTests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mvn install -Pdocker -DskipTests
mvn -B clean install -Pdocker -DskipTests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

java -version
javac -version
mvn install -Pdocker -DskipTests
mvn -f tests/pom.xml test -DintegrationTests No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mvn -f tests/pom.xml test -DintegrationTests
mvn -f tests/pom.xml -DintegrationTests -DredirectTestOutputToFile=false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Choose jdk 8
Update commands
@aahmed-se
Copy link
Contributor Author

Just a general question, how do we get the surefire-reports for each job? In other words, how do I know which tests are failing and where can I find the error log?

You can download the logs of each job as such.

Screen Shot 2019-08-28 at 1 52 15 PM

@sijie
Copy link
Member

sijie commented Aug 28, 2019

You can download the logs of each job as such.

Downloading the logs doesn't address the question I raised. First of all, the test logs are not sent to console directly. So the log of the job doesn't provide any useful information. Secondly, even you configure redirect the test output to console. You end up get a huge file for all the output for all the tests. It is almost impossible to get any useful information.

If you take a look at jenkin jobs, we collect the surefire-reports into archive. so you can check the output for individual tests. That helps quickly locate the errors for the given test.

https://builds.apache.org/job/pulsar_precommit_java8/11065/artifact/

@merlimat merlimat added this to the 2.5.0 milestone Aug 28, 2019
@aahmed-se
Copy link
Contributor Author

Added archiving and uploading sure fire artifacts

@sijie
Copy link
Member

sijie commented Aug 29, 2019

@aahmed-se as discussed in the email thread, it seems Github Action is not a solution for Pulsar. Can we close the related pull requests?

@aahmed-se
Copy link
Contributor Author

Will leave this one open close all the others.

@aahmed-se aahmed-se closed this Nov 13, 2019
@aahmed-se aahmed-se deleted the ci_1 branch November 13, 2019 05:48
@sijie sijie removed this from the 2.5.0 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants