[doc] Improve Pulsar Deployment Kubernetes#5102
Merged
sijie merged 3 commits intoapache:masterfrom Sep 13, 2019
Merged
Conversation
Contributor
Author
|
@Anonymitaet could you please spare some time review it? thank you~ |
Anonymitaet
requested changes
Sep 3, 2019
site2/docs/deploy-kubernetes.md
Outdated
| ``` | ||
|
|
||
| By default, bookies will run on all the machines that have locally attached SSD disks. In this example, all of those machines will have two SSDs, but you can add different types of machines to the cluster later. You can control which machines host bookie servers using [labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels). | ||
| By default, bookies run on all the machines that have locally attached SSD disks. In this example, all of those machines have two SSDs, but you can add different types of machines to the cluster later. You can control which machines host bookie servers can use [labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels). |
Member
There was a problem hiding this comment.
Suggested change
| By default, bookies run on all the machines that have locally attached SSD disks. In this example, all of those machines have two SSDs, but you can add different types of machines to the cluster later. You can control which machines host bookie servers can use [labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels). | |
| By default, bookies run on all the machines that have locally attached SSD disks. In this example, all of those machines have two SSDs, but you can add different types of machines to the cluster later. You can control which machines host bookie servers using [labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels). |
site2/docs/deploy-kubernetes.md
Outdated
| ``` | ||
|
|
||
| Create SSD disk mount points on the VMs using this script: | ||
| Create SSD disk mount points on the VMs using this command: |
Member
There was a problem hiding this comment.
Suggested change
| Create SSD disk mount points on the VMs using this command: | |
| Create SSD disk mount points on the VMs using this script: |
This is a script rather than a command
sijie
added
doc
Anonymitaet
approved these changes
Sep 10, 2019
Contributor
Author
|
run java8 tests |
Contributor
Author
|
run java8 tests |
1 similar comment
Contributor
Author
|
run java8 tests |
sijie
approved these changes
Sep 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the language and the overall descriptive style of the Pulsar Security document (deploy-Kubernetes section): http://pulsar.apache.org/docs/en/next/deploy-kubernetes/
Modifications
Adjust the tone, personal pronouns, voice also some typo errors of some sentences in the document.