Skip to content

Add option to customize splitter character #5187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merlimat merged 1 commit into from
Sep 13, 2019
Merged

Add option to customize splitter character #5187

merlimat merged 1 commit into from
Sep 13, 2019

Conversation

@aahmed-se
Copy link
Contributor

@aahmed-se aahmed-se commented Sep 12, 2019

This change allows a user of the pulsar-client to produce string messages with a custom spitting character for multiple messages , the default if unspecified is comma as before.

#5186

@aahmed-se aahmed-se requested review from merlimat and sijie September 12, 2019 21:42
@aahmed-se aahmed-se self-assigned this Sep 12, 2019
@aahmed-se aahmed-se mentioned this pull request Sep 12, 2019
Closed
@aahmed-se
Copy link
Contributor Author

aahmed-se commented Sep 12, 2019

run cpp tests

@aahmed-se
Copy link
Contributor Author

aahmed-se commented Sep 13, 2019

run integration tests

@merlimat merlimat added area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages labels Sep 13, 2019
@merlimat merlimat added this to the 2.5.0 milestone Sep 13, 2019
@merlimat merlimat merged commit c04945e into apache:master Sep 13, 2019
@aahmed-se aahmed-se deleted the splitter1 branch September 13, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie Awaiting requested review from sijie

Assignees

@aahmed-se aahmed-se

Labels

area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@aahmed-se @merlimat