Expose metrics of Caffeine caches #5320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
jerrypeng
reviewed
Oct 6, 2019
| public static final io.prometheus.client.cache.caffeine.CacheMetricsCollector CAFFEINE = new io.prometheus.client.cache.caffeine.CacheMetricsCollector() | ||
| .register(); | ||
|
|
||
| public static final io.prometheus.client.guava.cache.CacheMetricsCollector GUAVA = new io.prometheus.client.guava.cache.CacheMetricsCollector() |
Contributor
There was a problem hiding this comment.
Where is this being used?
Contributor
Author
There was a problem hiding this comment.
I was initially planning to instruments also Guava caches, though the remaining ones we have are not very interesting, so dropped the ball.
I have removed guava now. PTAL.
merlimat
changed the title
Contributor
Author
|
run java8 tests |
sijie
approved these changes
Oct 24, 2019
Member
|
run integration tests |
1 similar comment
Contributor
Author
|
run integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Collect and expose metrics related to the Caffeine and Guava caches in brokers.
This will report the sizes, hit/misses rates and load latency.