Skip to content

[Doc] Add *authenticateMetricsEndpoint* option in administration-prox…#5406

Merged
merlimat merged 2 commits intoapache:masterfrom
PierreZ:docs/metrics_proxy
Oct 24, 2019
Merged

[Doc] Add *authenticateMetricsEndpoint* option in administration-prox…#5406
merlimat merged 2 commits intoapache:masterfrom
PierreZ:docs/metrics_proxy

Conversation

@PierreZ
Copy link
Copy Markdown
Contributor

@PierreZ PierreZ commented Oct 17, 2019

Hi!

I found a missing parameter on the documentation of the Pulsar-Proxy.

Motivation

The parameter authenticateMetricsEndpoint was explained in the Pulsar Configuration guide but not on the Pulsar-Proxy dedicated page.

Modifications

I added the missing parameter in the dedicated page, as it was the only missing parameter based on the main Pulsar Configuration guide.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Have a nice day 🌞

@merlimat merlimat added this to the 2.5.0 milestone Oct 18, 2019
@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 18, 2019
@merlimat
Copy link
Copy Markdown
Contributor

run java8 tests
run integration tests

@merlimat merlimat merged commit ba6dfaf into apache:master Oct 24, 2019
@PierreZ
Copy link
Copy Markdown
Contributor Author

PierreZ commented Oct 25, 2019

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants