[Issue 5392][documentation] Updating Docker command to work on Windows properly #5419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Oct 24, 2019
sijie
added
doc
Contributor
|
run java8 tests |
aahmed-se
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #5392. The Docker command listed in the docs didn't work correctly for Windows, causing confusing. The revised command:
VOLUME ["/pulsar/conf", "/pulsar/data"]), so it's getting created anyway. If we name it, we can re-use it for subsequent runs of the command and persist the data.I have tested the command on Linux and Windows. @junlia also confirms that it works on Windows. I didn't test on MacOS, but I'm certain it will work there too.