Skip to content

[Issue 5430][pulsar-flink] Flink connector sink should implement consumeDataStream for 1.9.0#5431

Closed
fhalim wants to merge 2 commits intoapache:masterfrom
fhalim:feature/sink_implement_consumedatastream
Closed

[Issue 5430][pulsar-flink] Flink connector sink should implement consumeDataStream for 1.9.0#5431
fhalim wants to merge 2 commits intoapache:masterfrom
fhalim:feature/sink_implement_consumedatastream

Conversation

@fhalim
Copy link

@fhalim fhalim commented Oct 21, 2019

Fixes #5430

Motivation

Should be able to write to Pulsar under Flink 1.9.0 application

Modifications

Added an implementation for StreamTableSink#consumeDataStream(DataStream) in the sink to make it compatible with Flink 1.9.0 blink.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added unit test that verifies that a DataStreamSink is returned and is not null

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If a feature is not applicable for documentation, explain why? (Covered by Flink APIs)

@jiazhai
Copy link
Member

jiazhai commented Oct 22, 2019

@yjshen to take a look

@sijie sijie added this to the 2.5.0 milestone Oct 24, 2019
@sijie
Copy link
Member

sijie commented Oct 31, 2019

As discussed in #5430, close this issue in favor of the integration in Flink community.

@sijie sijie closed this Oct 31, 2019
@sijie sijie removed this from the 2.5.0 milestone Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flink connector sink doesn't work on blink SQL context

3 participants