fix: bug in delayed messaging which prevented some messages from getting delivered#5489
Closed
jerrypeng wants to merge 2 commits into
Closed
fix: bug in delayed messaging which prevented some messages from getting delivered#5489jerrypeng wants to merge 2 commits into
jerrypeng wants to merge 2 commits into
Conversation
aahmed-se
approved these changes
Oct 29, 2019
codelipenghui
approved these changes
Oct 29, 2019
| @Test | ||
| public void test() throws Exception { | ||
|
|
||
| String topic = "testNegativeAcks-" + System.nanoTime(); |
Contributor
There was a problem hiding this comment.
Seems this test not related to negative acks.
Contributor
|
I think there's a much simpler fix to this issue. The root cause is we're getting out the messages out of the tracker but not doing anything with that. Will post separate PR. |
Contributor
Author
|
withdrawing in favor of #5499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in the delayed messaging delivery code which can skip delivery of messages.
If there is already a pending read i.e. havePendingReplayRead = true, messages are not delivered but never added back into the delayed message tracker, thus causing these messages to never to be delivered.
Modifications
When there is a pending read in progress, i.e. havePendingReplayRead=true, add the messages back into the delayed message tracker so they will get send the next time around.