Python API: add get_input_topics()#5526
Merged
Merged
Conversation
sijie
approved these changes
Oct 31, 2019
Contributor
Author
|
Failed test is cpp, appears unrelated to this change. |
c49cf09 to
bdbce13
Compare
merlimat
approved these changes
Oct 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5525
Motivation
Feature parity with Java and Go APIs
Modifications
Add
get_input_topics()to Python Context/ContextImplVerifying this change
(There are no existing test cases for other ContextImpl methods like
get_output_topic. But I have tested this locally within a pulsar function)Does this pull request potentially affect one of the following parts:
Documentation
PR Doc: add missing functions from Python context object #5524 addsAdded documentation under site2/get_output_topic;get_input_topicscan be added once that has been merged (or if this one is merged first, then I'll update Doc: add missing functions from Python context object #5524)