Fix license file in the distribution package#5578
Conversation
sijie
requested review from
codelipenghui,
jerrypeng,
jiazhai,
merlimat,
rdhabalia,
tuteng and
wolfstudy
|
Not sure why Jenkins didn't capture this error. But I noticed that the LICENSE file is not updated to date in #5574 |
|
run java8 tests |
merlimat
left a comment
merlimat
left a comment
There was a problem hiding this comment.
The check being disabled is my fault... I commented it out at some point when fixing the Jenkins build since after the forced Maven upgrade the list of dependencies picked by maven was making the check to always fail and block all the PRs.
Once we solved the maven issue (by pinning to 3.5 instead of 3.6), then I forgot to re-enable..
It's on now.
| - io.netty-netty-resolver-dns-4.1.43.Final.jar | ||
| - io.netty-netty-transport-4.1.43.Final.jar | ||
| - io.netty-netty-transport-native-epoll-4.1.43.Final-linux-x86_64.jar | ||
| - io.netty-netty-transport-native-epoll-4.1.33.Final-linux-x86_64.jar |
There was a problem hiding this comment.
Not directly related with this PR but this dependency doesn't look it's getting picked up correctly, we should pin the version correctly to avoid incompatibilities across versions.
There was a problem hiding this comment.
yes will do it in a separate pull request.
|
run java8 tests |
3 participants
No description provided.