fix setTxnidMostBits bug#5743
Merged
jiazhai merged 9 commits intoapache:masterfrom Nov 26, 2019
hangc0276:master
Merged
Conversation
…metheus/PrometheusMetricsGenerator.java format code style Co-Authored-By: Sijie Guo <guosijie@gmail.com>
…ty consideration, So if people already define environments in pulsar_env, those env vars will not be overridden by bkenv.sh
jiazhai
approved these changes
Nov 26, 2019
Member
|
Thanks @hangc0276 for the work. A suggestion: Please following pulsar contributing guide to checkout a new branch from master for each fix： http://pulsar.apache.org/en/contributing/, This will be good for your own branch and code management. |
Member
|
run java8 tests |
Contributor
Author
Thanks, i will follow the pulsar contributing guide next time. |
sijie
approved these changes
Nov 26, 2019
Member
|
run java8 tests |
sijie
added
area/client
area/transaction
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TypedMessageBuilderImpl::beforeSend function, when setting TxnIdMostBits field of msgMetadataBuilder, it sets into TxnidLeastBits field and override the original TxnIdLeastBits value.