[docs]Refine "The Pulsar Java client" content#5853
Merged
Jennifer88huang-zz merged 3 commits intoapache:masterfrom Dec 19, 2019
Merged
[docs]Refine "The Pulsar Java client" content#5853Jennifer88huang-zz merged 3 commits intoapache:masterfrom
Jennifer88huang-zz merged 3 commits intoapache:masterfrom
Conversation
Refine "The Pulsar Java client" content in aspects of grammar, spelling, wording, etc.
Contributor
|
@Anonymitaet Please help review this PR |
codelipenghui
added
the
doc
Contributor
There was a problem hiding this comment.
@atlantic2099 Thank you very much for your contribution.
You can follow Google Developer documentation style guide, and improve it to be better from the following aspects:
- Use active voice: https://developers.google.com/style/voice
- Use present tense: https://developers.google.com/style/tense
- Use second person: https://developers.google.com/style/person
- Try to avoid using "Here's"/"there be" and modal verbs in technical writing. See IBM style guide.
- Pay attention to styles for code sample: https://developers.google.com/style/code-samples
atlantic2099
added a commit
to atlantic2099/pulsar
that referenced
this pull request
Dec 15, 2019
It has been proposed in pull request apache#5853
Member
|
@jennifer88huang Please review it again? |
jiazhai
approved these changes
Dec 17, 2019
Contributor
|
Is there any update after I leave comments? |
Jennifer88huang-zz
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To refine the document.
Modifications
Refine "The Pulsar Java client" content in aspects of grammar, spelling, wording, etc.