Skip to content

Vagrantfile update for build dependency#5968

Merged
sijie merged 3 commits intoapache:masterfrom
zuquan-song:master
Jan 1, 2020
Merged

Vagrantfile update for build dependency#5968
sijie merged 3 commits intoapache:masterfrom
zuquan-song:master

Conversation

@zuquan-song
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #5967

Motivation

Cannot build the project successfully.

Modifications

Add install commands to install the unzip zip tools when vm sets up

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (don't know)
  • The default values of configurations: ( no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: ( no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@zuquan-song
Copy link
Contributor Author

It's weird that my update affects the Jenkins Unit Tests because I just modify the Vagrantfile. Anyone could help? Thanks!

@zuquan-song
Copy link
Contributor Author

run java8 tests

@tuteng
Copy link
Member

tuteng commented Dec 31, 2019

run cpp tests
run java8 tests
run integration tests

@tuteng
Copy link
Member

tuteng commented Dec 31, 2019

run cpp tests
run java8 tests

@zuquan-song
Copy link
Contributor Author

run cpp tests

@sijie sijie added this to the 2.6.0 milestone Jan 1, 2020
@sijie sijie merged commit babce5e into apache:master Jan 1, 2020
@sijie sijie modified the milestones: 2.6.0, 2.5.0 Jan 6, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
Fixes apache#5967

### Motivation
Cannot build the project successfully.

### Modifications
Add install commands to install the unzip zip tools when vm sets up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vagrantfile problem

3 participants

Comments