Skip to content

Conversation

@abrahamsangha
Copy link

@abrahamsangha abrahamsangha commented Jan 17, 2020

The pulsar-admin CLI lists --className as the correct option; this change will match the CLI. Also corrects --trigger-value; it should be --triggerValue

The CLI lists `--className` as the correct option
@Jennifer88huang-zz Jennifer88huang-zz added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. area/function labels Jan 21, 2020
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abrahamsangha, the --classname and --trigger-value is working properly, they are compatible mode, so --classname and --className are both ok.

@wolfstudy
Copy link
Member

Currently, the help command of bin/pulsar-admin functions create displayed content is as follows

    --classname
       The function's class name

To ensure consistency, I think the current behavior is reasonable.

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abrahamsangha, just a little comment, PTAL

@jiazhai
Copy link
Member

jiazhai commented Apr 2, 2020

@abrahamsangha Would you please handle @wolfstudy 's comments regarding the className and

    --classname
       The function's class name

@Anonymitaet
Copy link
Member

Hi @abrahamsangha any progress on this PR?

@dave2wave
Copy link
Member

This PR is evidently stale or abandoned. Reopen if this is not so.

@dave2wave dave2wave closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/function doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants