-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[docs] Update functions-deploy.md #6072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CLI lists `--className` as the correct option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abrahamsangha, the --classname and --trigger-value is working properly, they are compatible mode, so --classname and --className are both ok.
|
Currently, the help command of To ensure consistency, I think the current behavior is reasonable. |
wolfstudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abrahamsangha, just a little comment, PTAL
|
@abrahamsangha Would you please handle @wolfstudy 's comments regarding the className and |
|
Hi @abrahamsangha any progress on this PR? |
|
This PR is evidently stale or abandoned. Reopen if this is not so. |
The pulsar-admin CLI lists
--classNameas the correct option; this change will match the CLI. Also corrects--trigger-value; it should be--triggerValue