Revert "Support for python native logging from python wrapper (#6113)" #6174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
changed the title
sijie
requested review from
codelipenghui,
jiazhai,
merlimat,
rdhabalia and
tuteng
codelipenghui
approved these changes
Jan 31, 2020
Contributor
Member
Author
|
@sbourkeostk seem my comment in #6172 (comment) |
sijie
commented
Jan 31, 2020
|
|
||
| - name: run unit tests pulsar proxy | ||
| run: mvn test -DfailIfNoTests=false '-Dtest=ProxyTest,ProxyLookupThrottlingTest' -pl pulsar-proxy | ||
| - name: run proxy lookup throttling test |
Member
Author
There was a problem hiding this comment.
ProxyTest runs in the flaky test suite.
jiazhai
approved these changes
Feb 3, 2020
tuteng
approved these changes
Feb 3, 2020
…and-function-state' into fix_integration_tests
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…#6113)" (apache#6174) As stated in apache#6171, change apache#6113 broke the function instance runner. This change attempts to revert apache#6113 first to make sure CI back to normal. Additionally, it fixes and improves a bunch of integration tests. (unfortunately, we have to couple these changes to make sure it pass CI).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #6171, change #6113 broke the function instance runner. This change attempts to revert #6113 first to make sure CI back to normal.
Additionally, try to fix integration tests