[Issue 5992][Helm chart] Helm chart bug fixes#6565
Closed
nicknezis wants to merge 2 commits intoapache:masterfrom
Closed
[Issue 5992][Helm chart] Helm chart bug fixes#6565nicknezis wants to merge 2 commits intoapache:masterfrom
nicknezis wants to merge 2 commits intoapache:masterfrom
Conversation
sijie
requested changes
Apr 5, 2020
| zkServers: | ||
| {{- $global := . }} | ||
| {{ range $i, $e := until (.Values.zookeeper.replicaCount | int) }}{{ if ne $i 0 }},{{ end }}{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}-{{ printf "%d" $i }}.{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}{{ end }} | ||
| {{ range $i, $e := until (.Values.zookeeper.replicaCount | int) }}{{ if ne $i 0 }},{{ end }}{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}-{{ printf "%d" $i }},{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}{{ end }} |
Member
There was a problem hiding this comment.
I don't think this change is correct.
Before this change, it generates zkServers as the following settings:
pulsar-dev-zookeeper-0.pulsar-dev-zookeeper,pulsar-dev-zookeeper-1.pulsar-dev-zookeeper,pulsar-dev-zookeeper-2.pulsar-dev-zookeeper
But after your change, it generates a wrong list:
pulsar-dev-zookeeper-0,pulsar-dev-zookeeper,pulsar-dev-zookeeper-1,pulsar-dev-zookeeper,pulsar-dev-zookeeper-2,pulsar-dev-zookeeper
Although the wrong list can be used without problems, it doesn't seem to the right fix.
Member
|
Close this issue now since the helm chart has been moved to https://github.com/apache/pulsar-helm-chart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #5992
Motivation
The Helm chart failed to work because of the two typos fixed in this PR.
Modifications
Describe the modifications you've done.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation