[pulsar-client-tools] add tls truststore and hn-verification option to argument #6742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhai
previously approved these changes
Apr 16, 2020
Member
|
/pulsarbot run-failure-checks |
sijie
requested changes
Apr 20, 2020
| String tlsTrustCertsFilePath; | ||
|
|
||
| @Parameter(names = { "--tls-allow-insecure" }, description = "Allow TLS insecure connection") | ||
| Boolean tlsAllowInsecureConnection = null; |
Member
There was a problem hiding this comment.
This is a boxed value.
I think you need to change the value assignments in PulsarClientTool constructor.
this.tlsAllowInsecureConnection = Boolean
.parseBoolean(properties.getProperty("tlsAllowInsecureConnection", "false"));
this.tlsEnableHostnameVerification = Boolean
.parseBoolean(properties.getProperty("tlsEnableHostnameVerification", "false"));
this.tlsTrustCertsFilePath = properties.getProperty("tlsTrustCertsFilePath");
Contributor
Author
There was a problem hiding this comment.
yes, that's correct. I fixed it.
Contributor
|
@rdhabalia Could you please take a look at sijie's comments? |
Contributor
|
move to 2.7.0 first. |
Member
|
Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow configure
tlsTrustCertsFilePathtlsAllowInsecureConnectiontlsEnableHostnameVerificationusing CLI argument in pulsar-client tools.