[CI] Group disabled components under the same tag in the clusters values#6762
Merged
jiazhai merged 1 commit intoapache:masterfrom Apr 18, 2020
vzhikserg:group-disabled-components-under-components-in-clusters-values
Merged
[CI] Group disabled components under the same tag in the clusters values#6762jiazhai merged 1 commit intoapache:masterfrom vzhikserg:group-disabled-components-under-components-in-clusters-values
jiazhai merged 1 commit intoapache:masterfrom
vzhikserg:group-disabled-components-under-components-in-clusters-values
Conversation
jiazhai
approved these changes
Apr 18, 2020
vzhikserg
deleted the
group-disabled-components-under-components-in-clusters-values
branch
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…values (apache#6762) ### Motivation It is harder to maintain the values if they are defined in different places in the documents. Some yaml editors display an error for the duplicated tags. ### Modifications The disabled components were grouped under the same tag (components)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It is harder to maintain the values if they are defined in different places in the documents. Some yaml editors display an error for the duplicated tags.
Modifications
The disabled components were grouped under the same tag (components)