[docs] Fix encryption examples#6763
Merged
sijie merged 2 commits intoapache:masterfrom Apr 27, 2020
Forescout:docfixes
Merged
Conversation
jiazhai
reviewed
Apr 18, 2020
Member
|
Thanks for the work. left a comments |
sijie
added
the
doc
sijie
approved these changes
Apr 20, 2020
Member
|
@jiazhai can you review it again? |
Anonymitaet
reviewed
Apr 24, 2020
Co-Authored-By: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
kjaggann
reviewed
Apr 28, 2020
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
* Fix encryption examples * Minor grammar fix Co-Authored-By: Yu Liu <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
gaoran10
pushed a commit
to gaoran10/pulsar
that referenced
this pull request
May 5, 2020
* Fix encryption examples * Minor grammar fix Co-Authored-By: Yu Liu <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
* Fix encryption examples * Minor grammar fix Co-Authored-By: Yu Liu <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
* Fix encryption examples * Minor grammar fix Co-Authored-By: Yu Liu <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Yu Liu <50226895+Anonymitaet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Examples for encryption were incorrect, they were a mix of Java and C++ and could not be used as is.
Modifications
Update the examples code and some texts
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation